Giters

httpwg / http2-spec

Working copy of the HTTP/2 Specification

Home Page:https://httpwg.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Section 6.5.2 (comment 9)

mnot opened this issue · comments

commented

Section 6.5.2: As compared to other parameter
definitions in this document, this text reads oddly and is a bit
confusing at first: the first sentence defines behavior when the
parameter is unset, where most or all of the other parameter
definitions appear to define behavior when set. Would it help to
update as suggested?

Original:

 SETTINGS_ENABLE_PUSH (0x2):  This setting can be used to disable
    server push ([Section 8.4](https://www.rfc-editor.org/authors/rfc9113.html#section-8.4)).  A server MUST NOT send a PUSH_PROMISE
    frame if it receives this parameter set to a value of 0.

Suggested:

 SETTINGS_ENABLE_PUSH (0x2):  This setting can be used to enable or
    disable server push.  A server MUST NOT send a PUSH_PROMISE frame
    if it receives this parameter set to a value of 0 ([Section 8.4](https://www.rfc-editor.org/authors/rfc9113.html#section-8.4)).
commented

Probably fine. We could nitpick the wording a bit, but I think the suggestion is reasonable.