Only watch .hs and .lhs files

Question

Only watch .hs and .lhs files

sol opened this issue 8 years ago · comments

I'm considering to make his change. Please raise your voice if you have an option on it.

Matvey Aksenov · Answer 1 · Wed Mar 23 2016 16:19:33 GMT+0800 (China Standard Time)

I find reloads on changes to .cabal files useful, too.

Also, ideally, sensei would reload on changes to the files added by addDependentFile, although I don't know if it's possible to easily get them from GHC currently.

Sönke Hahn · Answer 2 · Wed Mar 23 2016 16:23:48 GMT+0800 (China Standard Time)

sensei does not consider the cabal file, does it? So it shouldn't behave differently before and after changes to the cabal file. Or am I missing something?

Matvey Aksenov · Answer 3 · Wed Mar 23 2016 16:32:14 GMT+0800 (China Standard Time)

It does reload the spec for me when I change the project's cabal file. (I'm on 9545f0a.)

Sönke Hahn · Answer 4 · Wed Mar 23 2016 16:46:36 GMT+0800 (China Standard Time)

AFAIU sensei currently watches all the files in the directory. If anything changes, it re-runs the test-suite. So if you have a completely unrelated file (say foo.txt) and you change that, sensei will re-run the test-suite, but you will always get the same result. (Assuming your test-suite doesn't read foo.txt.)

The same is true for the cabal file. sensei is using ghci under the hood, which doesn't look at the cabal file. So, if you change the cabal file, sensei will re-run the test-suite, but the result will always be the same. (Assuming your test-suite doesn't read the cabal file.)

At least that's my understanding. Did you encounter a situation, where you changed something in the cabal file and then got a different result from sensei than before the change?

Matvey Aksenov · Answer 5 · Wed Mar 23 2016 17:14:17 GMT+0800 (China Standard Time)

Oh. Yeah, you're right, the reload doesn't change anything. Nevermind then, I don't have any objections to watching for changes in *.hs and *.lhs files only.

Autumn Russell · Answer 6 · Wed Jan 06 2021 17:04:50 GMT+0800 (China Standard Time)

It would be useful, at least, to have command line options to include or exclude files, maybe by regular expression match. Currently if you have other utilities watching the project directory, and if they end up modifying a file that isn't isBoring, it can cause sensei to run tests multiple times.

Simon Hengel · Answer 7 · Thu Jan 14 2021 19:55:35 GMT+0800 (China Standard Time)

@adrusi #43 will ignore everything that is ignored by git. I think this will already help in many situation.

However, situations where e.g. a test suite records files that are then subsequently committed can still result in looping behavior. I'm inclined to add support for .sensei.boring to address this.

Autumn Russell · Answer 8 · Thu Jan 14 2021 21:08:48 GMT+0800 (China Standard Time)

For my own use case, pulling from .gitignore is perfectly adequate, I'll benefit from the change, thanks. But yes, test artifacts that get committed aren't caught by this, and in fact the file that's been causing me unnecessary test runs is an lcov.info file generated by the test suite, which in my case I *do not* commit, but often would be. I mention this in case it helps you gauge how common a nuisance it would be.

…

On Thu, Jan 14, 2021, 06:55 Simon Hengel ***@***.***> wrote: @adrusi <https://github.com/adrusi> #43 <#43> will ignore everything that is ignored by git. I think this will already help in many situation. However, situations where e.g. a test suite records files that are then subsequently committed can still result in looping behavior. I'm inclined to add support for .sensei.boring to address this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABMYDKMICBCZ4MRSNKW4DTSZ3LUNANCNFSM4B62X2NA> .

Simon Hengel · Answer 9 · Mon Jan 30 2023 22:54:19 GMT+0800 (China Standard Time)

I'm not planning to do anything here at this point as .gitignore addresses my needs.