hrydgard / ppsspp

A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us on Discord at https://discord.gg/5NJB6dD or just send pull requests / issues. For discussion use the forums at forums.ppsspp.org.

Home Page:https://www.ppsspp.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

User report: Long notes in Rock Band Unplugged are not registered correctly

hrydgard opened this issue · comments

He tried using both touchscreen and a iPega 9087 controller, on Android.

When this was posted on the forums, quick google search said such issue with this game happens on real PSP as well when played with RemoteJoy and can be affected by PSP cpu clock, so it's most likely a timing issue.

Ah, didn't notice a forum post, I got an email. A timing issue of some sort would not surprise much indeed.

What sceCtrl polling method does it use? Cycle based on vblank based?

A log showing sceCtrl would answer this.

-[Unknown]

http://forums.ppsspp.org/showthread.php?tid=24949&pid=133406#pid133406

This person makes it sound like it's some sort of controller issue?

-[Unknown]

According to the latest posts it seems to be a regression from 1.6.3. Bumping priority to 1.8.0.

Will this issue ever get fixed? I saw a video on youtube from 2015 that managed to do sustained notes on Android. The top commenter posted two months ago that they are having the same issue of not being able to do sustained notes.

I also tried it on 1.6.3 on Mac and I'm still having this issue.

@Hacsev you could help significantly by trying to find when it stopped working. Unfortunately, I don't think there's a history of Mac builds, but if you're willing to use Xcode (it's free from Apple, but a large download) you could try different versions to find out when the bug was introduced.

There have been around 8000 individual changes since 2015. Since I don't experience the issue in other games, and don't have the Rockband game - that leaves me just staring at a haystack, wondering where the golden needle is.

You, in comparison to me, have a super power. By testing one version half way between 2015 and now, you could eliminate 4000 of those changes as being the problem in one fell swoop. You're the hero of this story - by testing just 14 different builds of PPSSPP, you would mow down all the small fry and find either the exact change that introduced this problem, or very close to.

It will probably be fixed eventually either way, but it'll probably be fixed a lot sooner if you're willing.

-[Unknown]

This is probably fixed now. Can anyone confirm using the latest git build?

It's currently building so make sure to check 20 minutes after the time of this comment.

-[Unknown]

@unknownbrackets Well, I got up to this point and it failed with ./b.sh --qtbrew:

[100%] Linking CXX executable PPSSPPQt.app/Contents/MacOS/PPSSPPQt
No such file: /Users/----/Downloads/ppsspp/build/PPSSPPSDL.app/Contents/MacOS/PPSSPPSDL!
make[2]: *** [PPSSPPQt.app/Contents/MacOS/PPSSPPQt] Error 1
make[2]: *** Deleting file `PPSSPPQt.app/Contents/MacOS/PPSSPPQt'
make[1]: *** [CMakeFiles/PPSSPPQt.dir/all] Error 2
make: *** [all] Error 2

I used ./b.sh and it built successfully with the latest git build. I tried Rock Band Unplugged and can confirm that the issue with long notes has been fixed.

Great, thanks for confirming.

The Qt issue is a separate bug, but probably this line:

if(TARGET SDL2::SDL2)

Should be if(NOT USING_QT_UI) or something. Or maybe macbundle should support Qt...

Going to close this issue, though.

-[Unknown]