Moving songs up/down in queue does not work
x51mon opened this issue · comments
Describe the bug
I can not change the order of songs in the queue with the shortcuts Shift+Up and Shift+Down, which are listed in the help menu.
To Reproduce
Steps to reproduce the behavior:
- Add multiple songs to queue
- Select song at the bottom
- Press Shift+Up
- Nothing happens
Expected behavior
Selected song moves up one position in the queue.
System (please complete the following information):
- OS: Linux
- Terminal: Konsole (KDE)
- Version: 0.13.2-3
- Installed from: AUR
Additional context
Not quite sure if it is a bug or I broke something on my side. I've installed ncspot quite some time ago, but I changed very few options and never tried to change keyboard shortcuts. Moving songs hasn't worked for a while, I'm not sure if the function worked in the past.
Hrrrm, what I found so far: seems to be Termion backend related. With (pa)ncurses the bindings work fine.
I have built version 0.13.4 on Arch from source with --features ncurses_backend and --features pancurses_backendand it didn't fix it for me. I've now remapped them to Shift+j and Shift+k in ~/.config/ncspot/config.toml. That makes them work again for now and it's similarly convenient, as you can also use j and k without Shift for moving around.
[keybindings]
"Shift+j" = "shift down"
"Shift+k" = "shift up"
btw: The shift command is not documented in the list of vim-like commands. ;-)
@moabeat-berlin Did you also pass --no-default-features?
No, of course I oversaw that. With this additional option (and also passing the rest of the default features), it works perfectly now! I added this as an alternative AUR package. Thanks for the help!
@moabeat-berlin I have set it to build ncspot with crossterm by default. Can you check if that works as well?
@hrkfdn Works fine now! I used the build parameters from the original Arch package on the masterbranch and nothing else.
@moabeat-berlin Good to know, thanks! :)
Solved via #1290