feature request: merge login menus
ohitstom opened this issue · comments
currently i have to guide users to the main url + /my/account, would be nice if the main login thing was all in one?
I believe they are kept separate for a reason, the login at the base URL is for managing jfa-go itself whereas /my/account is for managing the users profile itself. Users can get access to the main jfa-go dashboard so doing this would probably create odd behaviour (and users who have access to the dash wouldn't be able to sign into the /my/account end). One could probably whip up some smart behavior to avoid these conflicts but it seems like more trouble than it's worth.
That said I think it'd be a good idea to give jfa-go admins the option (not sure if it exists already) to serve /my/account on the base URL and put the jfa-go dash in a subpath (essentially reversing the current behaviour) so that users have a simpler URL to log into.
I'll add an option to manually set the My Account and Admin page subfolders at some point. For now you can probably do this yourself with a reverse proxy.
I believe they are kept separate for a reason, the login at the base URL is for managing jfa-go itself whereas
/my/accountis for managing the users profile itself. Users can get access to the main jfa-go dashboard so doing this would probably create odd behaviour (and users who have access to the dash wouldn't be able to sign into the /my/account end). One could probably whip up some smart behavior to avoid these conflicts but it seems like more trouble than it's worth.That said I think it'd be a good idea to give jfa-go admins the option (not sure if it exists already) to serve /my/account on the base URL and put the jfa-go dash in a subpath (essentially reversing the current behaviour) so that users have a simpler URL to log into.
that is true but nothing is stopping querying both login endpoints from one form, try admin query if it fails try jellyfin/user query or however that works
no real reason this isnt one menu all it would require is extra logic, that being said this is a thing on unstable which basically solves the issue but it again begs to question why the two werent just merged:
They aren't merged because each portion of this app (admin, user page, registration form) is a single page, no page reloads occur on the admin page, and having a combined log in page for both the admin and user page would mean one of them or both would have to redirect on a successful login. The "Not an Admin?" thing and the ability to hide the background on that screen were simple additions, combining the two login pages would be a bigger one and would probably worsen the experience for those who don't use the "My Account" feature.
They aren't merged because each portion of this app (admin, user page, registration form) is a single page, no page reloads occur on the admin page, and having a combined log in page for both the admin and user page would mean one of them or both would have to redirect on a successful login. The "Not an Admin?" thing and the ability to hide the background on that screen were simple additions, combining the two login pages would be a bigger one and would probably worsen the experience for those who don't use the "My Account" feature.
I don't see why you'd need a page reload idk what language is being used here but it's not hard to change endpoints on a failed request no? unless the my account section is checking the db?
maybe having the main page not just be an overlay over the admin panel and actually be its own page so we dont need multiple login pages for the same thing then redirect to the correct page after login, kinda like how embystat is
that's my point, it'd require a redirect. I'd potentially do this if I gave the login page a bit more content, so maybe I'd add it alongside extra stuff like custom messages, logos, etc. If i did it wouldn't be for a little while, maybe in 5.2.
that's my point, it'd require a redirect. I'd potentially do this if I gave the login page a bit more content, so maybe I'd add it alongside extra stuff like custom messages, logos, etc. If i did it wouldn't be for a little while, maybe in 5.2.
yeah thats fine, i think it would be nice to have but the way things are in unstable are perfectly good for now