OpusCleaner get stuck on ASGI error when adding filters while sample is still loading
jelmervdl opened this issue · comments
Found on Paracrawl zh-en by Nick.
After all these months, I finally figured it out!
Changed in version 3.8:
CancelledError
is now a subclass ofBaseException
rather thanException
.
The sampling process got cancelled, but it didn't get removed from the sample cache. So now you're basically always awaiting a cancelled future, which throws a CancelledError that isn't caught by any of my normal except
clauses because they're written as except Exception as err:
, which, for the attentive listeners out there, is not a base class of CancelledError
.