hopfenspace / MateBot

Micro service providing an API for MateBot clients

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Divide the big base classes into smaller pieces to clean up and improve the code's structure

CrsiX opened this issue · comments

commented

There are mainly two big base classes, BaseBotUser and BaseCollective, as well as the BackendHelper class which is not treated as base class in this issue. Those two classes share some pretty similar code which should be cleaned up as well, see #20. However, there are different aspects that don't really come together in the collective's base class, e.g. handling multiple messages and handling users as well as providing some methods for the collective feature (add_message, add_user and amount respectively, for some examples). This should be structured in a better way and finally combined in a much smaller BaseCollective class which might want to take advantage of multiple inheritance as well.

commented

The code fragments that seem to be similar in both base classes are too different to join the functionality in one base class (except for the stuff already moved into BackendHelper).