hood / popui.nvim

NeoVim UI sweetness.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CodeAction seems broken

Freyskeyd opened this issue · comments

Hello,

I use NvChad with Popui everything works fine except code_action and diagnostics.

Screenshot 2022-11-03 at 11 58 23

How can I debug this ?

it seems that it's due to the absence of vim.g.popui_border_style

Good morning, and thank you for using the plugin! I guess the broken part you're referring to is the missing popup borders, right? Have you tried setting them eplicitly?

You can define the borders style by setting

let g:popui_border_style = PREFERRED_STYLE

In your vimrc

Yes, it fixed the issue for code_action but not for diagnostics :x

@Freyskeyd I have added a default fallback style for borders. Can you pull the latest version and check whether it fixes the issue for the diagnostics popup, too?

It didn't, but I'm using the default binding for diagnostics.

Screenshot 2022-11-03 at 13 03 11

Yes, I don't think you are popui.nvim at all for diagnostics.

You should spawn popui.nvim's popup for navigating diagnostics by doing something the likes of:

nnoremap <YOUR_KEYMAP_HERE> :lua require'popui.diagnostics-navigator'()<CR>

I'm using binding to trigger: vim.diagnostic.goto_prev

Maybe we can add popui to that too

vim.diagnostic.goto_prev() shouldn't display a popup at all IIRC, it's just a command that teleports the cursor to some coordinates.
The popup you displayed in this comment is just the default popup for diagnostics you get on a given line.
What is the feature that you feel should be incoprporated in popui.nvim?

having the default popup override by popui.nvim ? I don't know if it's possible tho

I don't see much value in doing that. The only real "benefit" we'de get would be a different style for the title. Custom borders in native NeoVim popups can already be configured by passing

{
	border = "rounded",
}

to the handler.