honkit / honkit

:book: HonKit is building beautiful books using Markdown - Fork of GitBook

Home Page:https://honkit.netlify.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Could not jump between footnote reference and definition in some cases

lindeer opened this issue · comments

Summary

If footnote label contains '.', jumping between reference and definition would failed. I think this issue was caused by our gitbook.js or theme.js, 'cause when I removed them, jumping is OK.

markdown-it's label rendering is different with other markdown library, but that is ok, Also an old bug since gitbook, hope it could be fixed.

  • HonKit version: 4.0.4

Step to reproduce

  1. in one page file, insert a footnote reference whose label contains '.'
  2. after rendering, click footnote reference
  • Link to code example:
some text[^130.1].

<large amount of content, so that page could be 'scrollable'>

[^130.1]: some footnote definition.

Expected results

jump to footnote definition.

Actual results

nothing happened.

commented

Maybe #286 is similar issue.

Fundamentally, I feel that replacing the Markdown parser is a good idea. #96

I think this case may not caused by Markdown parser, when I removed gitbook.js and theme.js, jumping is fine. sorry for no more details.