Connection class doesn't resubscribe to events if event_type empty

[Jason]

Not sure if this is intended but if you subscribe to subscribe_events with an empty event_type the connection class won't resubscribe to subscribe_events on a reconnect to the websocket.

home-assistant-js-websocket/lib/connection.ts

Lines 89 to 110 in ff15397

   if (oldSocket) { 
     const oldCommands = this.commands; 
  
     // reset to original state 
     this.commandId = 1; 
     this.commands = {}; 
  
     Object.keys(oldCommands).forEach(id => { 
       const info = oldCommands[id]; 
  
       if (info.eventType) { 
         this.subscribeEvents(info.eventCallback, info.eventType).then( 
           unsub => { 
             info.unsubscribe = unsub; 
           } 
         ); 
       } 
     }); 
  
     this.fireEvent("ready"); 
   } 
 } 

[Paulus Schoutsen]

Yeah that is weird 🤔

[Paulus Schoutsen]

Could you share what you're building?

[Jason]

I have forked node-red-contrib-home-assistant and have converted it to start using websocket and the new auth system, well once you guys release the long-lived access token (home-assistant/core#16453).

Hopefully plan on having something pushed to the public in short order. It's my first real big open source project and pretty sure that I am trying to make it to prefect before releasing it.

[Paulus Schoutsen]

That's awesome!