Giters

holidays / holidays

A collection of Ruby methods to deal with statutory and other holidays. You deserve a holiday!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Project updates

hlascelles opened this issue · comments

commented

Hi @ppeble ....

This is a great project, and we love using the rubygem, but it looks like it is in need of some updates. I know answering a slew of issues can be tiring (and open source is best effort), but there are also quite a number of unmerged/uncommented PRs (ie people doing work and contributing). I really do understand that this gem more than most will need frequent releases which will be a strain! Also very hard to code review - who knows if a country holiday submission is right.

Is this project active? Are there other maintainers? Thanks again for the project!

commented

@ppeble following what @hlascelles said, is it possible to add some contributors to the project? I offer myself.

We have suffered a problem with coronation of King Charles III as bank holiday and in our system wasn't a holiday because the definition wasn't updated.

commented

I finally forked the gem and applied that PR.

Also I've tried to contact @ppeble but was unsuccessful. I hope he can read at some point this issue.

commented

@ppeble @ttwo32 Our organization is looking to contribute to this gem as well. Is it possible to widen the group of contributors/maintainers? Our need is mostly on the definitions front (ie. the list of holidays isn't comprehensive, or in some cases out of date/incorrect).

commented

Could be possible to have a new release of the gem with the latest updates?

commented

Yes, I will do a release this week. 🙇

commented

Thank you @ppeble

commented

I hit some snag with testing, I'm still going to work through it this week. Sorry for the delay!

commented

I have released v8.8.0 with the latest definitions: https://github.com/holidays/holidays/releases/tag/v8.8.0

Sorry for the delay! Please keep poking me for updates, I very much want to maintain this but I am not a daily user of this gem so I need to expand our maintainer list. Recent events around adding maintainers make me very nervous. 😁

I will work on that front but in the meantime please keep bugging me. I give everyone permission to ping me and bother me until I do the needful. 🙇

I am leaving this open so I have a source of shame to drive me. 😄

commented

@ppeble thank you so much for your work ;)