Giters

holidays / holidays

A collection of Ruby methods to deal with statutory and other holidays. You deserve a holiday!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Japan National Holidays in 2018 are incorrect

irwalker opened this issue · comments

commented

Hi there,

A couple of problems with holidays in Japan for 2018:

  • 2018-04-30 was observed Showa day, but it is not recognised in releases >= 7.0

  • 2018-05-07 is coming through as a holiday (I think as observed Children's day) but it should not be, as public holidays that fall on a Saturday are not carried forward.

I think I could create a PR to fix observed Showa day, but I am not sure about the second issue.

Japan public holidays for 2018

Thanks,
Iain