UK May Day still on the wrong day

Question

UK May Day still on the wrong day

jacobwalkr opened this issue 5 years ago · comments

Hi all,

Slightly niggly issue: although May Day has been moved to the 8th in holidays/definitions, there's no version of holidays (either through rubygems or github @ master) that reflects this.

Any idea when that change might make its way to rubygems? I'm working around it by forking atm :)

Cheers,
Jacob

ttwo32 · Answer 1 · Mon Dec 02 2019 18:46:03 GMT+0800 (China Standard Time)

Hi @jacobwalkr. Sorry for the lazy response.
UK May Day will be changed to May 8 only in 2020, right?
Perhaps it has already been fixed, so take a look this PR. :)

jacob · Answer 2 · Tue Dec 03 2019 00:25:31 GMT+0800 (China Standard Time)

Hi @ttwo32

No problem.

The issue wasn't that definitions was wrong - that version just hadn't been bundled with the holidays gem yet. Looks like there was a new release (8.0) made a few weeks after I posted this and it looks to have the newest version of the definitions.

Thanks :)