Federal reserve error for holidays in 2018
musa-raza opened this issue · comments
Hello, for federal reserve holidays, there is an error in your generator. Veterans day is on the 12th of November this year, not the 11th. https://www.newyorkfed.org/aboutthefed/holiday_schedule.html
@musa-raza See the footnote next to the 2018 date for Veteran's Day on the page you linked to.
It falls on November 11th this year, which is a Sunday, so it is observed on Monday, November 12th.
If you want Holidays to return the dates holidays are observed, you need to pass the observed flag, like so: Holidays.year_holidays([:federal_reserve, :observed], Date.today)