holidays / holidays

A collection of Ruby methods to deal with statutory and other holidays. You deserve a holiday!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Canadian Thanksgiving missing

joffet opened this issue · comments

Hi, great gem btw. Works great. Is it possible to get Canadian Thanksgiving? ( second Monday every October ) https://en.wikipedia.org/wiki/Thanksgiving_(Canada)

The others on my wishlist are Christmas Eve and New Years Eve in the informal category.

Thanks again for the fine work

Thanksgiving is already part of the list, are you experiencing it missing?
https://github.com/holidays/holidays/blob/master/lib/generated_definitions/ca.rb#L53

Ah, I see. I have to make the locale province specific. I guess there are some provinces that don't recognize it. Thanks

@slucaskim Thank you for answer this issue!!
@joffet Please feel free to ask more. :)
Thanks!!