How are the holidays updated

Question

neumachen opened this issue 8 years ago · comments

How are the holidays updated on this gem?

Phil Peble · Answer 1 · Thu Sep 08 2016 23:18:39 GMT+0800 (China Standard Time)

Hi @magicalbanana, we outline how to do it in our CONTRIBUTING guide. In short:

Fork the repository
Edit desired definition YAML file(s) located under definitions/. If you are adding a new region be sure to update definitions/index.yaml as well
Run make generate to generate updated final definitions (they will be located under lib/generated_definitions/ and test/defs/)
Run make test to ensure your changes did not introduce errors
Open a PR with all of these changes. You MUST include the generated definition files and tests in your PR. There is no automatic process to generate definitions at this time

Information on the definition format itself can be found here.

We check in both the original YAML and the generated final ruby files. Let me know if you have any other questions!

Phil Peble · Answer 2 · Thu Sep 08 2016 23:20:31 GMT+0800 (China Standard Time)

And I thought recognized your username. I work at @sittercity. 😄

Kareem H · Answer 3 · Thu Sep 08 2016 23:28:11 GMT+0800 (China Standard Time)

Hehehe. Thanks for the quick response.

Phil Peble · Answer 4 · Thu Sep 08 2016 23:31:09 GMT+0800 (China Standard Time)

No problem! Going to go ahead and close the issue. 👍