Composer: PSR-4

Question

Composer: PSR-4

Hywan opened this issue 10 years ago · comments

Hello :-),

Composer provides a PSR-4 autoloader since several months now. We didn't switch from PSR-0 to PSR-4 in composer.json files because we didn't know how many services are using the latest Composer version. I don't know more right now but I think we can say that we have waited enough time.

Why will it help?

Hoa's autoloader was already PSR-4. We have pointed out the lakes of PSR-0 many times since the origin of PSR-0 but… this is another topic. Anyway, Hoa's autoloader is PSR-4. Consequently, using the same autoloader specification will help to drop specific Composer's code (mainly when accessing to resources). It will help to drop the following code:

Modifing all composer.json

We will have to modify all the composer.json files at once and pushing everything at once. This will be like a small rush (potentially around 2-3am to avoid errors). I can create PR for every composer.json files, however, I will start by the one of this library in order to agree on the upcoming patches.

Thoughts?

/cc @hoaproject/hoackers

Sébastien HOUZÉ · Answer 1 · Fri Aug 22 2014 16:45:14 GMT+0800 (China Standard Time)

👍 we use PSR-4 since few months and it's pretty cool

Stéphane PY · Answer 2 · Mon Aug 25 2014 16:02:43 GMT+0800 (China Standard Time)

Composer is not in stable mode, users/services have to upgrade theirs composer.

Ivan Enderlin · Answer 3 · Mon Aug 25 2014 16:05:06 GMT+0800 (China Standard Time)

@stephpy What does it mean?

Stéphane PY · Answer 4 · Mon Aug 25 2014 16:17:44 GMT+0800 (China Standard Time)

We didn't switch from PSR-0 to PSR-4 in composer.json files because we didn't know how many services are using the latest Composer version.

Related to that, if users have a version of composer which doesn't support psr-4, they should upgrade it ...

Ivan Enderlin · Answer 5 · Mon Aug 25 2014 16:24:31 GMT+0800 (China Standard Time)

@stephpy: What is the source of your quote?

Stéphane PY · Answer 6 · Mon Aug 25 2014 16:33:02 GMT+0800 (China Standard Time)

@Hywan you ? 3 days ago. In top of this page.

Ivan Enderlin · Answer 7 · Mon Aug 25 2014 16:42:03 GMT+0800 (China Standard Time)

@stephpy :-p. Ok. Yes of course they have to upgrade their own version of Composer. Is it a problem?

Stéphane PY · Answer 8 · Mon Aug 25 2014 17:07:45 GMT+0800 (China Standard Time)

Nope ;) Let's go for PSR-4.

Ivan Enderlin · Answer 9 · Wed Dec 10 2014 02:00:45 GMT+0800 (China Standard Time)

All libraries have a PR updating the composer.json file. Hoa\Core has also a PR to update the behavior of hoa://Library/. Everything is ready. I will merge all that stuff tomorrow.

Ivan Enderlin · Answer 10 · Wed Dec 10 2014 17:24:30 GMT+0800 (China Standard Time)

Everything works. Back to work.

Bonus with #44, now hoa://Library looks inside the parent of the vendor/ directory when installed through Composer. Thus:

$ git clone https://github.com/hoaproject/Ruler . # for instance
$ composer install
$ vendor/bin/hoa test:run -d Test

now works (it previously failed because hoa://Library/ were only resolved inside vendor/hoa/).

Thanks everyone for the help!