hoaproject / Core

The Hoa\Core library.

Home Page:https://hoa-project.net

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

from()->setRoot() needs a ending '/' (Linux) or '\' (Windows)

1e1 opened this issue · comments

commented

Usually, I never write the last directory separator when I set a path.
So this code fails:

from('Devengers')
-> setRoot('/home/agerlier/Documents/Libraries.hoa')
-> import('Hero.Identity~')
-> import('Hero.Kit.Uuid')
;

The correct Hoa syntax is -> setRoot('/home/agerlier/Documents/Libraries.hoa/')
Perhaps, we should add an implicit ending directory separator in the Core?

Hello :-),

Yup, definitively. Any PR?

commented

Hmm, not yet not yet.
In the same idea, I see Core::initialize should be refactored: all paths end by DS. They should be removed. As __DIR__, dirname() and cie return.

Ok, I will do it.

Hi,
Should resolve function will be affected ? hoaproject/Http#3

Ok, thanks.

@1e1 Does #34 solve your issue?

#34 is merged. I close this issue.