Delete functionality for add-remove enhancement inconsistant

Question

Delete functionality for add-remove enhancement inconsistant

MarkPaxton opened this issue 8 years ago · comments

Re: http://hmrc.github.io/assets-frontend/section-add-remove.html

There is no way to delete the first line, but you may delete any other. If you make a mistake on the first line and want to remove it you cant without a workaround.

Ben Chidgey · Answer 1 · Thu Oct 06 2016 22:59:59 GMT+0800 (China Standard Time)

@MarkPaxton this is were context would help. I think the initial implementation always wanted 1 input on the page. It would be worth speaking with the designer or devs on the teams slack channel

Ben Chidgey · Answer 2 · Thu Oct 06 2016 23:03:23 GMT+0800 (China Standard Time)

So if the functionality of the first input being removed is needed this would become a chat to the teams who use it and a PR with an update to tests

Mark Paxton · Answer 3 · Thu Oct 06 2016 23:05:15 GMT+0800 (China Standard Time)

It's just a limitation as a general purpose component that might prevent reuse, I have no need to change it

Ben Chidgey · Answer 4 · Thu Oct 06 2016 23:08:43 GMT+0800 (China Standard Time)

Sure, another thing that design and ourselves have spoken about is providing context besides components/design patterns on the component library, why is X like this. That will then help inform people around decisions made.