evil-mulitedit broken with recent iedit changes
CeleritasCelery opened this issue · comments
A recent commit to iedit breaks evil-multiedit--substitute
and evil-multiedit--paste-replace
. I was able to bisect the offending commit down to victorhge/iedit@be44da7. It is a pretty large commit so I was not able to find out what actually causes the regression.
FYI @victorhge
This is a known issue that I am working on a fix for. For the time being I've pinned iedit to 77eb0a1e2e44b453e4ebf4c38409affa353f5139
in Doom Emacs. If you aren't using Doom you'll have to do similar for now.
@ema2159 Yes
Any news on this?
lsp-mode introduced a new feature using iedit and some functions that are not available on older iedit versions :/
It'd be really cool fix this issue to bump iedit on doom-emacs
c/c @hlissner
Sorry for the late response. As of a451370 evil-multiedit should work fine with the latest commit of iedit, so I'll consider this issue resolved. Let me know if that isn't the case and I'll reopen it.
@ericdallo Thanks for letting me know! I'll bump Doom's module soon. Also, sorry to spring this on you: 36904ce introduced a breaking change I've been sitting on for some time; lsp-evil-multiedit-highlights
and lsp-evil-multiedit-linked-ranges
will need to be updated:
- (evil-multiedit-state))
+ (evil-multiedit-mode +1))
My access to a dev machine is unstable so it'll be a couple days before I can PR it myself, so feel free to snipe it if you'd like.
Great! I'll make the proper changes on lsp-mode, thank you for the huge help on this!
Fixed on lsp-mode