hivewallet / hive-js

Hive digital currency wallet

Home Page:http://www.hivewallet.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Low-S ECDSA signatures

losh11 opened this issue · comments

Please implement low-s ECDSA signatures, as when Litecoin Core 0.10.3 is release, no block will accept any transactions signed without.

@w-hive

hive is based off bitcoinjs-lib, which afaik has supported low-s for a loooooooooong time.

Whether it's in the compiled apps on each respective app store, idk.

Losh do you need me to take further action on this? It sounds like you'll need to bake in the latest bitcoinjs-lib.

"bitcoinjs-lib": "^1.2.0",

Release 0.3.3 of hive-js has ^1.2.0 for the bitcoinjs-lib dependency.

https://github.com/bitcoinjs/bitcoinjs-lib/blob/cfcfe59520f1c24d6b1174dbf769d778a5484fce/src/ecdsa.js#L71

bitcoinjs-lib @ 1.2.0 supports LowS signatures.

This issue should be closed.