mycontestbox Bug
AceDZN opened this issue · comments
Hey there!
just discovered another bug - when I click on one of the entries it open the mycontestbox - but when I Click on the mycontest left\right arrows it show the same image 2-3 times until it loads the next image.
it looks like it happens because you have 2-3 tags inside the masonry-brick div [1) wrapping div.cn | 2) wrapping img.retina ]
also - if the contest voting ended then it totally breaks the tags wrapping:
<div class="myContest-entry masonry-brick" style="width: 224px; position: absolute; top: 0px; left: 468px;">
<div class="ribbon-wrapper-green">
<div class="ribbon-green">3rd</div>
</div>
<p>
<a href=".../Temple-Of-Heaven.jpg" rel="myContest-gallery" class="mycontestbox nofancybox" data-title="Temple of Heaven, China" data-title-id="caption51e658d62c697">
</a>
</p>
<div class="cn" style="width: 224px; height: 144px;">
<a href=".../Temple-Of-Heaven.jpg" rel="myContest-gallery" class="mycontestbox nofancybox" data-title="Temple of Heaven, China" data-title-id="caption51e658d62c697">
<div class="icon-zoomin" style="top:56px;left:96px;"></div>
</a>
</div>
<a href=".../Temple-Of-Heaven.jpg" rel="myContest-gallery" class="mycontestbox nofancybox" data-title="Temple of Heaven, China" data-title-id="caption51e658d62c697">
</a>
<p>
<a href=".../Temple-Of-Heaven.jpg" rel="myContest-gallery" class="mycontestbox nofancybox" data-title="Temple of Heaven, China" data-title-id="caption51e658d62c697"><img src=".../Temple-Of-Heaven-224x144.jpg" data-retina=".../Temple-Of-Heaven-500x322.jpg" alt="Temple of Heaven, China" class="retina" width="224px" height="144px"></a>
</p>
<div class="caption">
<h3 class="entrytitle">Temple of Heaven, China</h3>
<h4 class="entryauthor">by Leila Nor</h4>
<p>Thought of an original place. </p>
</div>
<div class="meta-act">
<div class="meta-share"><a href="#" class="share-button"><span class="share-icons social-share-icon-share"></span>Share</a></div>
<div class="share-links">
<div class="group">
{{SOCIAL SHARE - REMOVED IT BECAUSE IT'S TOO LONG TO HERE :) }}
</div>
</div>
</div>
<p>
<a href="#vote" class="myContest-votes-button disabled" disabled="disabled"><span class="myContest-count">56 votes</span></a>
</p>
<div id="caption51e658d62c697" style="display:none;"></div>
</div>because of the tag breaks I can't open the mycontestbox for the 3 winning entries (with the ribbon on them)
I will test this on my side and let you know.
You Can check it out on my site, You already have an account there
I see the problem and am working on fixing this.
ACE, you found ?
What have I found?
I found the problem & the procedure that gives the error - but I don't totally swimming at this plugin code - even though I'm making some custom modifications to it on each update.
in this case I'm a little bit confused - but maybe it's just because I'm always so tired when I working on that site :\
What is the problem you found?
no found just bug, we r waiting for resolve
I am changing from my custom solution to either fancybox or lightbox 2. Have a preference?
fancybox for me : )
I know I asked but I did not realize that fancybox has a commercial license fee of $89. I think I will actually do lightbox 2. 😆
very nice ^^
🌴
I am going to sound like a crazy person but I received an email from another client and they suggested Magnific Popup. Here is a smashing magazine article on it. I think it fits everything, so I am adding right now.
aha you'r not mad, you are a developer XD
good luck for implement
This is being a pain
I figured out what is causing the problem with my plugin...
ah ?? update soon may be : )
GL
Ya, it is the overlay that is causing this for some reason (the zoom icon on hover)
I asked a friend and waiting on his response if he has a suggestion how to fix this.
Simple js solution (from me) and fixed!!!! Just moved the zoom out of the container into a holder and then move with js when initialized. This fixes the problem and the zoom will still not show on non-js. Here is the js to fix it:
// Move and Display the magnify hover as we have js
mcb = $('.mycontestbox');
cn = mcb.siblings('.cn-holder');
h = cn.html();
cn.remove();
// Setup myconstestbox
mcb.myContestbox({
beforeLoad: function() {
var el, id = $(this.element).data('title-id');
// New line
this.title += '<br />';
if (id) {
el = $('#' + id);
if (el.length) {
this.title += el.html();
}
}
}
}).append(h);I will look at moving to a different lightbox solution at a later date since this fixed it (I think traveling at 60 mph helps for some reason). Fixed in version 2.0.3 coming out soon in the beta update once I test it some more.
dont forget share click problem button friend : )
and good job !!
I know
BTW try the new update when I release it and let me know if it fixes it as well. You are the only person I have seen have the social problem.
uh O_o theme conflict may be
I am not sure if it is or not but I am going to make sure. I have a speech today that I am presenting and I will work on this tomorrow.
Fixed this in version 2.0.4. I am releasing to the beta channel now. Check and let me know.
I am going to assume this is fixed
I don't know because I didn't got any updates for a long time now
On Aug 12, 2013 6:09 PM, "Kyle King" notifications@github.com wrote:
I am going to assume this is fixed
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/52#issuecomment-22499960
.
What do you mean that you have not gotten any updates?