Some missing bits according to the license

Question

Some missing bits according to the license

lelutin opened this issue 4 years ago · comments

Hello,

While inspecting the codebase for preparing a debian package with it, I saw that there were some details that were missing according to the license that you've chosen for the codebase:

There should be a NOTICE file at the top
each source code file should have a short header comment that mentions the license and a copyright attribution

To find out more details about the two points, you can check out the following URL: https://infra.apache.org/apply-license.html

Gabriel Filion · Answer 1 · Mon Dec 21 2020 15:51:13 GMT+0800 (China Standard Time)

I was corrected by somebody else.. the presence of those elements are optional and the document specifically is a guideline for Apache developers.

sorry for the useless noise

Brandon High · Answer 2 · Mon Dec 21 2020 16:24:56 GMT+0800 (China Standard Time)

Thank you for looking into it and bring diligent enough to resolve it yourself! I appreciate that you were paying close enough attention to detail that you noticed this. Please do not hesitate to reach out in the future if you notice something else that is amiss.

…

On Sun, Dec 20, 2020, 11:51 PM Gabriel Filion ***@***.***> wrote: I was corrected by somebody else.. the presence of those elements are optional and the document specifically is a guideline for Apache developers. sorry for the useless noise — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFZQKGGUPK2SL7LW3KEV5DSV35ABANCNFSM4VDXLDXQ> .