Giters

hienngm / nestjs-graceful-shutdown

A powerful package for gracefully shutting down NestJS applications.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Doubt about process RabbitMQ messages

Jaben1tez opened this issue · comments

commented

  • I'm submitting a ...
    [ ] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository
    [x] question about how to use this project

  • Summary
    Hi @hienngm,
    thank you very much for sharing this library, it's really useful when you are working with NestJS, but there is something for me which is not clear. I don't know if it is taking into account the messages which are being currently processing have finished before shutting down the application. I mean... let's suppose that we have a NestJS application which is exposing a HTTP api but also it is consuming messages (asynchronously) from other services through RabbitMQ (or any message broker).

My question is:
Is this library waiting to process those messages before to shutdown the application?

Thanks and best regards.

P.D. I saw something interesting that maybe it can be added also to your library to complete it and do it more robust (nestjs-rabbitmq-transporter-graceful-shutdown)

commented

Hi @Jaben1tez,
I appreciate your interest in enhancing the library. I'll certainly review your suggestion, but it's worth noting that introducing new features might not be a priority unless there's substantial demand for them.