hhvm / type-assert

Hack library for converting untyped data to typed data.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

3.18 Breaks things :(

HRMsimon opened this issue · comments

File "/builds/HRMWEB/easyEMPLOYER/vendor/fredemmott/type-assert/src/TypeAssert.php", line 81, characters 9-30:
'instanceof' cannot be used on a generic classname because types are erased at runtime (Typing[4162])

I just added // UNSAFE in the method, but you may have a nicer way of doing it (like a FIXME, I was just lazy). Was hoping that Hack would've been fixed before the release, but apparently not.

Fix will be tagged once travis finishes :)

A wild v1.1 appears - it's super effective!

Hooray! :)