Build packages for ubuntu 20.10 groovy gorilla
lexidor opened this issue · comments
This interim release was released at the 22nd of October.
Copying the methodology of #238 didn't work for me.
I got to /opt/hhvm-distro-packaging/make-package using the instructions from the README file Local interactive usage. The last lines of compiler output were ⬇️.
I have no cpp experience and have therefore no idea if this output is useful to anyone attempting to build hhvm for ubuntu 20.10.
/tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/third-party/folly/src/folly/Format-inl.h: In function 'void folly::FormatValue<folly::dynamic>::format(folly::FormatArg&, FormatCallback&) const [with FormatCallback = folly::BaseFormatter<Derived, containerMode, Args>::appendTo<std::__cxx11::basic_string<char> >::<lambda(folly::StringPiece)>]':
/tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/third-party/folly/src/folly/Format-inl.h:496:10: note: at offset -1 to object 'valBuf' with size 67 declared here
496 | char valBuf[valBufSize];
| ^~~~~~
In member function 'void folly::FormatValue<T, typename std::enable_if<(std::is_integral<_Tp>::value && (! std::is_same<T, bool>::value))>::type>::doFormat(folly::FormatArg&, FormatCallback&) const [with FormatCallback = folly::BaseFormatter<Derived, containerMode, Args>::appendTo<std::__cxx11::basic_string<char> >::<lambda(folly::StringPiece)>; T = int]',
inlined from 'void folly::FormatValue<T, typename std::enable_if<(std::is_integral<_Tp>::value && (! std::is_same<T, bool>::value))>::type>::format(folly::FormatArg&, FormatCallback&) const [with FormatCallback = folly::BaseFormatter<Derived, containerMode, Args>::appendTo<std::__cxx11::basic_string<char> >::<lambda(folly::StringPiece)>; T = int]' at /tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/third-party/folly/src/folly/Format-inl.h:437:13,
inlined from 'void folly::FormatValue<bool>::format(folly::FormatArg&, FormatCallback&) const [with FormatCallback = folly::BaseFormatter<Derived, containerMode, Args>::appendTo<std::__cxx11::basic_string<char> >::<lambda(folly::StringPiece)>]' at /tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/third-party/folly/src/folly/Format-inl.h:650:36,
inlined from 'void folly::FormatValue<folly::dynamic>::format(folly::FormatArg&, FormatCallback&) const [with FormatCallback = folly::BaseFormatter<Derived, containerMode, Args>::appendTo<std::__cxx11::basic_string<char> >::<lambda(folly::StringPiece)>]' at /tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/third-party/folly/src/folly/dynamic-inl.h:1197:48:
/tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/third-party/folly/src/folly/Format-inl.h:617:26: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
617 | *--valBufBegin = '0';
| ~~~~~~~~~~~~~~~^~~~~
/tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/third-party/folly/src/folly/Format-inl.h: In function 'void folly::FormatValue<folly::dynamic>::format(folly::FormatArg&, FormatCallback&) const [with FormatCallback = folly::BaseFormatter<Derived, containerMode, Args>::appendTo<std::__cxx11::basic_string<char> >::<lambda(folly::StringPiece)>]':
/tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/third-party/folly/src/folly/Format-inl.h:496:10: note: at offset -2 to object 'valBuf' with size 67 declared here
496 | char valBuf[valBufSize];
| ^~~~~~
make[3]: Leaving directory '/tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:1690: third-party/mcrouter/CMakeFiles/mcrouter.dir/all] Error 2
make[2]: Leaving directory '/tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:133: all] Error 2
make[1]: Leaving directory '/tmp/hhvmpkg.FJ8psrnA/hhvm-nightly-2020.11.04/obj-x86_64-linux-gnu'
dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j4 returned exit code 2
make: *** [debian/rules:5: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui failed
- mcrouter issue fixed in master, but excluding tools/ (like we exclude mcrouter tests and examples) is a simpler fix, and reduces build time
- new issue, easy fix:
/tmp/hhvmpkg.6I6840Lb/hhvm-nightly-2020.12.01/hphp/runtime/vm/as.cpp: In constructor 'HPHP::AssemblerError::AssemblerError(int, const string&)':
/tmp/hhvmpkg.6I6840Lb/hhvm-nightly-2020.12.01/hphp/runtime/vm/as.cpp:112:10: error: type 'std::runtime_error' is not a direct base of 'HPHP::AssemblerError'
112 | : std::runtime_error(
| ^~~~~~~~~~~~~
cp "/tmp/hhvmpkg.6I6840Lb/hhvm-nightly-2020.12.01/obj-x86_64-linux-gnu/hphp/hack/default/src/hh_single_type_check.exe" "/tmp/hhvmpkg.6I6840Lb/hhvm-nightly-2020.12.01/obj-x86_64-linux-gnu/hphp/hack/bin/hh_single_type_check"""
/tmp/hhvmpkg.6I6840Lb/hhvm-nightly-2020.12.01/hphp/runtime/vm/as.cpp: In function 'std::unique_ptr<HPHP::UnitEmitter> HPHP::assemble_string(const char*, int, const char*, const HPHP::SHA1&, const HPHP::Native::FuncTable&, bool)':
/tmp/hhvmpkg.6I6840Lb/hhvm-nightly-2020.12.01/hphp/runtime/vm/as.cpp:3698:56: error: 'struct HPHP::AssemblerError' has no member named 'what'
3698 | ue = createFatalUnit(sd, sha1, FatalOp::Runtime, e.what());
| ^~~~
/tmp/hhvmpkg.6I6840Lb/hhvm-nightly-2020.12.01/hphp/runtime/vm/as.cpp:3701:56: error: 'const struct HPHP::AssemblerFatal' has no member named 'what'
3701 | ue = createFatalUnit(sd, sha1, FatalOp::Runtime, e.what());
Should be straightforward, just leaving a note for me to come back to :)
I have a working build locally, HHVM diffs waiting for review. Will look at packaging config once those are in HHVM master.
Whoops, no, this should be open until I add it to CURRENT_TARGETS
There's now a repository for groovy, and a package for yesterday's nightly
Automated nightly build succeeded
4.87 has a groovy package; will try to backport to 4.80
This was done a long while back, I forgot to close the issue though