Apply patches/ before creating source tarball, and remove

Question

Apply patches/ before creating source tarball, and remove

fredemmott opened this issue 5 years ago · comments

Fred Emmott commented 5 years ago

Not doing this immediately to minimize changes while fixing debian-8-jessie

Ján · Answer 1 · Sat Oct 26 2019 05:05:17 GMT+0800 (China Standard Time)

should we do this now?

Fred Emmott · Answer 2 · Tue Oct 29 2019 09:17:57 GMT+0800 (China Standard Time)

this would still be good, but low-impact...

... on the other hand, if we're patching the source tarballs, it could be a good way to inject the HSL and somewhat higher impact :)

Problem there is testing changes to the HSL itself; HHVM has mechanisms for this (runtime-optional-extensions), but i think we'd need something like __PHPStdLib, but for the HSL, to make the HHIs work