Known bad HHClientLinters need to be automatically unconditionally suppressed

Question

Known bad HHClientLinters need to be automatically unconditionally suppressed

fredemmott opened this issue 3 years ago · comments

Fred Emmott commented 3 years ago

See #368 (comment) and HackLintRule::HACK_LINT_IGNORED_CODES in FB www

This relates to #407 - we should never be raising 5583

Lexidor Digital · Answer 1 · Fri Nov 26 2021 23:06:05 GMT+0800 (China Standard Time)

Is code 5607 (identity comparison on disjoint types) on that list?

Fred Emmott · Answer 2 · Tue Nov 30 2021 05:13:21 GMT+0800 (China Standard Time)

Nope, I think you found a new bug :)

Yang, Bo · Answer 3 · Thu Dec 09 2021 08:47:15 GMT+0800 (China Standard Time)

This relates to #407 - we should never be raising 5583

I created #419 to ignore 5583

Yang, Bo · Answer 4 · Fri Dec 10 2021 07:58:02 GMT+0800 (China Standard Time)

Fixed in #419 and #422

Fred Emmott · Answer 5 · Fri Dec 10 2021 10:18:30 GMT+0800 (China Standard Time)

For reference, the other codes in the FB list are either already deleted from the Ocaml code, or are in the 6xxx range; the 6xxx range requires Zoncolan, which is sadly not open source :(