Skipping test in `beforeTestAsync` /sometimes/ leads to a non-zero exit

[Fred Emmott]

Run vendor/bin/hacktest tests/*.hack
2
  vendor/bin/hacktest tests/*.hack
3
  shell: /bin/bash -e {0}
4
......
5

6
Summary: 6 test(s), 6 passed, 0 failed, 0 skipped, 0 error(s).
7

8
Fatal error: Uncaught exception 'Facebook\HackTest\SkippedTestException' with message 'Fallback handler is not enabled' in /home/runner/work/hhvm-autoload/hhvm-autoload/vendor/hhvm/hacktest/src/Framework/HackTest.hack:266
9
Stack trace:
10
#0 /home/runner/work/hhvm-autoload/hhvm-autoload/tests/FallbackHandlerTest.hack(20): Facebook\HackTest\HackTest::markTestSkipped()
11
#1 /home/runner/work/hhvm-autoload/hhvm-autoload/vendor/hhvm/hacktest/src/Framework/HackTest.hack(156): Facebook\AutoloadMap\FallbackHandlerTest->beforeEachTestAsync()
12
#2 /home/runner/work/hhvm-autoload/hhvm-autoload/vendor/hhvm/hacktest/src/Runner/HackTestRunner.hack(78): Facebook\HackTest\HackTest->runTestsAsync()
13
#3 /home/runner/work/hhvm-autoload/hhvm-autoload/vendor/hhvm/hacktest/src/HackTestCLI.hack(103): Facebook\HackTest\HackTestRunner::runAsync()
14
#4 /home/runner/work/hhvm-autoload/hhvm-autoload/vendor/facebook/hh-clilib/src/CLIBase.hack(181): Facebook\HackTest\HackTestCLI->mainAsync()
15
#5 /home/runner/work/hhvm-autoload/hhvm-autoload/vendor/hhvm/hacktest/bin/hacktest.hack(36): Facebook\CLILib\CLIBase::runAsync()
16
#6 /home/runner/work/hhvm-autoload/hhvm-autoload/vendor/hhvm/hacktest/bin/hacktest(19): Facebook\HackTest\hack_test_main_async()
17
#7 (): Facebook\HackTest\hack_test_main_async_UNSAFE()
18
#8 (): Closure$__SystemLib\enter_async_entry_point()
19
#9 (): HH\Asio\join()
20
#10 (): __SystemLib\enter_async_entry_point()
21
#11 {main}

From https://github.com/hhvm/hhvm-autoload/runs/1323201059?check_suite_focus=true

Probably a non-awaited awaitable, given it's being raised after the '0 skipped' was printed