Creating a new instance of the Engine not thread safe.

Question

Creating a new instance of the Engine not thread safe.

dangershony opened this issue 7 years ago · comments

A static dictionary is initiated without locks.

Not sure if this is intentional.

See comments in our code: https://github.com/stratisproject/StratisBitcoinFullNode/blob/master/Stratis.Bitcoin/Utilities/DBreezeSingleThreadSession.cs#L85

blaze commented 7 years ago

v 1.089

blaze · Answer 1 · Fri Aug 25 2017 12:10:52 GMT+0800 (China Standard Time)

Will take a look on Tuesday

blaze · Answer 2 · Fri Aug 25 2017 12:16:22 GMT+0800 (China Standard Time)

But I didn't get the the problem actually, DBreeze instance is definitely thread safe. First instance must be initiated and only after that it must be consumed - that should be obviously, that's why, intentionally, dictionaries in the constructor of the instance are lockless.

Dan Gershony · Answer 3 · Fri Aug 25 2017 16:00:13 GMT+0800 (China Standard Time)

If you have 5 databases running in the same application and you need to create 5 engine instances where the creation is from 5 different threads you may get concurrncy errors due to shared static dictionary.

Thats fine if its intentional, but the instance creation is not thread safe.

We fixed it our side by protecting the initialization.