Reporting fix where `topic.error` is `None`

[Daniel Truemper]

I randomly see problems in pyvows when test['topic'].error == None. The code now only tests, if error is an attribute of the topic.

A hotfix 3e669eb is committed in a different branch (fix/reporting_with_none_error). I don't really know if there is any difference which is why I did not want to simply commit this in the master...

Cheers
Daniel

[Bernardo Heynemann]

I saw it. Go ahead and merge it to master.

Cheers,
Bernardo Heynemann

Bernardo Heynemann
Developer @ globo.com

[Zearin]

Is this the sort of bug we should write a test for PyVows own tests?

[Daniel Truemper]

Hi,

just discovered another problem:

Topic error:
Traceback (most recent call last):
  File "bin/pyvows", line 46, in <module>
    sys.exit(pyvows.console.main())
  File "[...]/pyVows-1.1.3-py2.7.egg/pyvows/console.py", line 153, in main
    reporter.pretty_print()
  File "[...]/pyVows-1.1.3-py2.7.egg/pyvows/reporting.py", line 79, in pretty_print
    self.print_context(context['name'], context)
  File "[...]/pyVows-1.1.3-py2.7.egg/pyvows/reporting.py", line 191, in print_context
    self.print_context(context['name'], context)
  File "[...]/pyVows-1.1.3-py2.7.egg/pyvows/reporting.py", line 174, in print_context
    exc_type, exc_value, exc_traceback = test['topic'].error
ValueError: need more than 1 value to unpack

Seems like there is no exception info but the exception itself? Any ideas where that comes from?

Best
Daniel

[Daniel Truemper]

@Zearin probably yes, but so far I have no idea where this comes from... :(

[Bernardo Heynemann]

Does this still reproduce against latest version?

[Zearin]

@truemped : Could you check if this still occurs in a fresh checkout from master?

[Bernardo Heynemann]

Any news on this ticket?

[Zearin]

I think this issue should be solved. Check out the current code that checks for topic errors.

Nevertheless, in the interest of being thorough, I’m writing a test for this issue. I’ll have a pull request up in a little bit.