heynemann / pyvows

Python implementation of Vows.js

Home Page:http://pyvows.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

teardown method not invoked if tests fail

jedp opened this issue · comments

If any tests fail within a Context, or there are any errors, the context's teardown() method doesn't get invoked.

Example:

https://gist.github.com/1829212

I think the teardown() method should always be invoked, regardless of any errors or failures, shouldn't it?

You are absolutely right. This is a bug with pyvows. This should be fixed. If you can fix, it would be SWELL! :) If not I'll fix it as soon as possible.

Thanks again for the report.
Bernardo Heynemann

Coolio. I'll try to fix, yes.
But it's good to know it's on your radar

Cheers!
j

I've submitted #21
So I'll close this thread

Sorry - bad protocol on my part. It's not mine to close now :)
I hope the patch works for you
cheers
j

hah! timing is everything
i see you've merged it
I've pulled and everything works great
thanks for being super fast, as always
j

Not at all!!! :) I should be the one thanking you for the contribution!!!

Cheers,
Bernardo Heynemann

On Wed, Feb 15, 2012 at 4:53 PM, Jed Parsons <
reply@reply.github.com

wrote:

hah! timing is everything
i see you've merged it
I've pulled and everything works great
thanks for being super fast, as always
j


Reply to this email directly or view it on GitHub:
#19 (comment)

a pleasure!
cheers
j