heynemann / pyvows

Python implementation of Vows.js

Home Page:http://pyvows.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

errors_in_topic_vows.py: Subcontexts don’t inherit from `Vows.Context`

Zearin opened this issue · comments

This is a bug introduced in #101.

@rcl33 Was nice enough to open the original issue, add a decorator, and write a test suite.

Unfortunately, the test suite passed because the subcontexts don’t inherit from Vows.Context. As a result, the tests were passing in spite of an uncaught error.

If you change the subcontexts to inherit from Vows.Context, the build fails.

I’m not sure how to rewrite the parts of the suite that say “this should not be reached” while still checking that they aren’t.

Help wanted! 😦

@Zearin could you let me know if it's still an issue?

I guess it's not an issue anymore since this commit 28a5ba