main-nav does not work recently
gaoming714 opened this issue · comments
navbar does not work on my site.
here is the HTML code on my Firefox.
<nav id="main-nav">
missing the Docs API News Plugins Themes
<a href="https://github.com/hexojs/hexo" rel="external nofollow noreferrer" class="main-nav-link"><i class="fa fa-github-alt"></i></a> <div id="search-input-wrap" class="on"> <div id="search-input-icon">
Sorry about that, fixed in #1173. Hexo.io should work properly now.
Perfect fix, but I have two questions about this issue.
Is it because agile development (rolling updates),which is causing such an issue that occasionally occurs?
Should I raise it the next time I encounter a small flaw?
Or wait a little bit for your fix. I know you're fixing fast.
We are indeed using continuous deployment, any commit made to the master branch of this repo is pushed to the website.
Before we merge the commit, we usually do the following:
- Code review
- Preview in localhost (if the change is significant)
- Check deploy preview
This issue is stemmed from #1139, which @SukkaW and I did performed local test, but we both forgot to check the deploy preview.
Aside from that mistake, another cause is that Netlify is very conservative on updating the hexo package that is sourced from the repo (instead of the usual npmjs), we want to use the latest commit of hexo package. We've only discovered this limitation recently.
We're currently exploring a few options to mitigate the limitation.
We do appreciate if you can let us know if similar issue comes up next time.