herotc / hero-rotation

WoW Addon - Attempt to provide the useful and precise information to execute the best possible DPS rotation in every situation.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug]: [Enhancement] Target Count Issue When Out of Range

nechyu opened this issue · comments

What feature would you like to have added?

There's a problem with the shaman switching between AOE and ST mode. When AOE mode is on, when we move away from the target we get a POOL icon. And if you switch to ST mode, it will show rotation and is coloured red as it is far away from the target. This is one problem.
The second problem in a quick change of abilities after the PWave lines if anything these are interested in
[Hero Rotation] primordial_wave main 24
[Hero Rotation] elemental_blast single 24
[Hero Rotation] lightning_bolt single 20
This is the sequence the addon often recommends. Sometimes hangs on elemental_blast. If you look at the rotation, elemental_blast only at the beginning of the rotation should be used, and in a long battle only this sequence should go like this.
[Hero Rotation] primordial_wave main 24
[Hero Rotation] lightning_bolt single 20

Fix these two things please. Happy New Year to you guys. Thanks for your addon.

The first issue should be fixed in commit 725f90e

The second issue should be fixed in commit 129cd8f

Unfortunately, the servers are currently down in my region and I can't copy my shaman to the PTR, so the changes are untested. I'll test them when the servers come back up.

I made a couple more changes and fixed a small bug. The profile should work as expected now.