heroku / heroku-buildpack-static

[DEPRECATED] Heroku buildpack for handling static sites and single page web apps

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build output doesn't display nginx version correctly

edmorley opened this issue · comments

The build output currently shows:

remote: -----> Installed directory to /app/bin

When it's meant to say:

remote: -----> Installed nginx/1.9.7 to /app/bin

This is because the nginx binary path used here is not correct (it should not have the -$STACK suffix):

nginx_version=$($build_dir/bin/nginx-$STACK -V 2>&1 | head -1 | awk '{ print $NF }')

This error isn't caught because the buildpack doesn't use bash's pipefail mode.