heroiclabs / nakama

Distributed server for social and realtime games and apps.

Home Page:https://heroiclabs.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Nakama-js can be timeout when pipeline.ProcessRequest return false

nguyentrannhan opened this issue · comments

Description

When pipeline.ProcessRequest return false, the nakama-js can be timeout because the IncommingLoop is break. To fix it, we add a flag for safely break the IncommingLoop

Steps to Reproduce

  1. Run nakama-js-webpack-example
  2. Run joinChat with wrong input
  3. Errors reported to client and in console log

Expected Result

nakama-js should return with invalid input error not socket timeout

Actual Result

Error is thrown with socket timeout

Context

  • nakama-js

Your Environment

  • Nakama: 2.7.1
  • Database: CockroachDB
  • Environment name and version: Development
  • Operating System and version: Window 10/Ubuntu 20.04

I don't understand what the issue is supposed to be here and its attempted fix. If you are sending a malformed payload that cannot be processed, the socket will be closed as intended. What is the "wrong input" you are sending in joinChat?

Discussed further on the PR here.