Nakama-js can be timeout when pipeline.ProcessRequest return false
nguyentrannhan opened this issue · comments
NccSoft Vietnam commented
Description
When pipeline.ProcessRequest return false, the nakama-js can be timeout because the IncommingLoop is break. To fix it, we add a flag for safely break the IncommingLoop
Steps to Reproduce
- Run nakama-js-webpack-example
- Run joinChat with wrong input
- Errors reported to client and in console log
Expected Result
nakama-js should return with invalid input error not socket timeout
Actual Result
Error is thrown with socket timeout
Context
- nakama-js
Your Environment
- Nakama: 2.7.1
- Database: CockroachDB
- Environment name and version: Development
- Operating System and version: Window 10/Ubuntu 20.04
Fernando Takagi commented
I don't understand what the issue is supposed to be here and its attempted fix. If you are sending a malformed payload that cannot be processed, the socket will be closed as intended. What is the "wrong input" you are sending in joinChat
?
Andrei Mihu commented
Discussed further on the PR here.