"5ms" are not 0.05s

Question

"5ms" are not 0.05s

BenWiederhake opened this issue 4 years ago · comments

Ben Wiederhake commented 4 years ago

https://github.com/hephaest0s/usbkill/blob/master/usbkill/usbkill.py#L140

1 millisecond is 0.001 seconds. Therefore, 5 milliseconds is 0.005 seconds.

I propose changing the comment, because 50 milliseconds is still quick enough.

Deleted user · Answer 1 · Fri Jun 30 2023 00:02:55 GMT+0800 (China Standard Time)

On my fork of USBKill, https://github.com/Dreadysa/usbkill-revived/ I have fixed this issue. This project is essentially dead, you will need to rely on forks.

Deleted user · Answer 2 · Thu Jul 27 2023 07:59:49 GMT+0800 (China Standard Time)

I am back under a different name because of a PII leak in my repo. I have also fixed this again on my usbkill-revived project.

I foolishly used my installation of USBKill for the code, I am using the code from this repo to modify instead on my new repo. PII leaks shouldn't happen anymore.