hendricius / the-sourdough-framework

Open source book dedicated to helping you to make the best possible sourdough bread at home.

Home Page:https://breadco.de/book

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Website looks weird on iOS / firefox

cedounet opened this issue · comments

and on Firefox/linux

Thanks. It seems something in general broke the website:

image

I will investigate 😎

All pics are wrongly sized by the look of it…. Ebooks are fine though.

It seems like the book.css doesn't have the full content somehow.

... Works locally. I will test on my Linux system and report back.

you might want to have a look at http://tug.tug.org/TUGboat/tb44-2/tb137island-docker.pdf ... Google some more there are slides and Youtube video. The repo is at https://islandoftex.gitlab.io/ most interesting for us is the docker image one...

Usual disclaimer, I know nothing about Docker so feel free to ignore.

@cedounet I went back in time commit by commit, seems like 4b4d80d is breaking it, PR #301

I see a lot of warnings when building the doc:

image

Also - now since I uploaded the artifacts - you can see it seems here the website build is also broken: https://github.com/hendricius/the-sourdough-framework/actions/runs/7152098004

Shame on me - I didn't check that before merging 🤦 .

Lets find out what is the issue - also - maybe we can fail the build process in the future if there is a bug like this.

@cedounet I can't really see though what's the issue. Maybe revert the PR first then try a little more relaxed with time?

Edit - I take it back. It seems to work now.... Investigating more.

@cedounet see #304. I found the problem. The problem is when you build the pdf and then directly after the website: make bake && make website. For some reason I need to clean the build with mrproper. I fixed it in the PR. Also added an error in case the website building fails.