[Feature request] Enable logs

Question

[Feature request] Enable logs

c157fl opened this issue 2 years ago · comments

Hi there!

Any way we could enable logs? I'm having trouble downloading some files (pdf, epub). Some start on desktop, others on neither, others on both. I checked the console (container and browser) but no relevant information and neither on the network tab (browser). On mobile I do see that some would be appearing as json extension when attempting to download.

Cheers,

Nhan Phan · Answer 1 · Sun Dec 18 2022 10:49:19 GMT+0800 (China Standard Time)

Hi, i'm adding more log to it too, some operation didn't show enough log quite hard to debug.

c157fl · Answer 2 · Mon Dec 19 2022 19:48:35 GMT+0800 (China Standard Time)

Hi,

Mostly getting epub and PDFs.
I think I have some more details on the failures. It seems to be platform specific. I could always download them on my Unix but not on my Windows machine. Used the same browser to be sure, Firefox and Brave.
If removing any special characters, I could download it on Brave but not on Firefox, both on the Windows machine.

Using dev docker image, just pulled today.

Nhan Phan · Answer 3 · Wed Dec 21 2022 10:10:16 GMT+0800 (China Standard Time)

Hi,

Mostly getting epub and PDFs. I think I have some more details on the failures. It seems to be platform specific. I could always download them on my Unix but not on my Windows machine. Used the same browser to be sure, Firefox and Brave. If removing any special characters, I could download it on Brave but not on Firefox, both on the Windows machine.

Using dev docker image, just pulled today.

Hi, try update your docker-compose.yml like this to see what error it is: https://github.com/help-14/mountain/blob/main/docker-compose.yml
I'll show error to frontend later this week.

c157fl · Answer 4 · Wed Dec 21 2022 21:58:21 GMT+0800 (China Standard Time)

Hi,

Already updated my docker compose a couple of days ago when @nhanpt updated with part of the logger code.
Curiously, I cannot download come files directly, for example the log file, but if I zip the file then I can download it.
Could it be related to the reply type of the request? Browser flags it as "Network Error".

Nhan Phan · Answer 5 · Thu Dec 22 2022 10:02:49 GMT+0800 (China Standard Time)

Hi, could you upload this file here so I can check it

c157fl · Answer 6 · Fri Dec 23 2022 23:00:06 GMT+0800 (China Standard Time)

Unfortunately I cannot update it publicly.
I can provide the logs, I renamed the file to have "---------" instead of many letters and still failed to download it like this:

GIN] 2022/12/23 - 14:55:12 | 200 | 610.907µs | 192.168.1.96 | GET "/api/get?path=/serve"
2022/12/23 14:55:14 Request to download from /serve/Ma----- ------ - -------_ ----------- ( (2021, --------).epub
[GIN] 2022/12/23 - 14:55:14 | 200 | 201.984µs | 192.168.1.96 | GET "/api/download?path=/serve/Ma-----%20------%20-%20-------_%20-----------%20(%20(2021,%20--------).epub"

While testing I figured out how to trigger it from an end-user perspective.
The issue is when encoding the filename. If I remove the "," from the filename then it downloads.

Nhan Phan · Answer 7 · Mon Dec 26 2022 22:27:25 GMT+0800 (China Standard Time)

@c157fl try again with latest dev image

c157fl · Answer 8 · Mon Dec 26 2022 23:15:50 GMT+0800 (China Standard Time)

@help-14 Tried now on both brave and chrome. Not able to download on either and also neither with or without ",". For the one with "," I get "Failed - Network error" while for the one without, I get a 0 bytes file.

Nhan Phan · Answer 9 · Mon Dec 26 2022 23:20:12 GMT+0800 (China Standard Time)

@help-14 Tried now on both brave and chrome. Not able to download on either and also neither with or without ",". For the one with "," I get "Failed - Network error" while for the one without, I get a 0 bytes file.

Strange, I changed file name as you suggest and still be able to download. Maybe it is a permission problem.

c157fl · Answer 10 · Tue Dec 27 2022 02:23:57 GMT+0800 (China Standard Time)

Regarding permissions, the container is running with the root user and the file is also as root/root.
My bad, apparently that file became corrupt somehow. I've gotten another file to test and the issue with the "," remains.
At this point the file name is either "Dav,.pdf" or "Dav.pdf". First one triggers the error, second one doesn't.

So, updated info:

Windows
- Brave Browser does not download file with the ","
- Firefox downloads both but for the one with "," does so at the cost of everything after the space (including file extension).
Android
- Brave does not
Linux
- Firefox works independently of the name.

Nhan Phan · Answer 11 · Tue Dec 27 2022 10:32:03 GMT+0800 (China Standard Time)

okay, maybe I'll add filter special character from file name when download.

Nhan Phan · Answer 12 · Sat Dec 31 2022 11:51:35 GMT+0800 (China Standard Time)

@c157fl Hi, try dev image again :)

c157fl · Answer 13 · Sat Dec 31 2022 19:22:28 GMT+0800 (China Standard Time)

Hi, did not notice any change :s, neither on windows nor on android.
Also, do you think you could put the build version/number under the about menu?

I did notice something new though. On mobile, when trying to rename, the file extension does not get sent as in, I get this in the logs:

2022/12/31 11:19:25 Request to rename from /serve/---/David to /serve/---/David,
2022/12/31 11:19:25 rename /serve/tor/David /serve/---/David,: no such file or directory

Filename is David.pdf though. In the mobile UI it does appear as renaming with the file extension but the text input field does not have the extension pre-filled.

Going to attach image of what I get on mobile when pressing to download.