Add support for other discovery selectors

Question

Add support for other discovery selectors

giurim opened this issue 5 years ago · comments

Currently only class discovery selector is supported. Add support for at least

path selector
modules selector

Gyorgy Mora · Answer 1 · Sun Jul 12 2020 23:45:26 GMT+0800 (China Standard Time)

Hi, at least for Gradle it is not the case. This issue is about other (afaik rarely used) features of Junit 5. The test runner and the Junit 5 environment works together. The environment "offers" things to discover (classes, files, etc) and the runner discovers the tests. In the case of class discovery Gradle enumerates all classes on the test classpath and the runner basically select all the classes which is assignable from the Scalatest Suite class (at least the last version does this). So as far as we know all Scalatest test should be discovered if this is not the case pls file a bug and I will look into it.

…

On Sun, Jul 12, 2020, 16:03 Stephane Landelle ***@***.***> wrote: Hi there, If I get this issue right, this plugin currently only supports discovering test classes whose name ends with "Test" and doesn't discover classes with different naming pattern but with classes or methods annotated @test. Am I correct? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#8 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADST4FLSSQVIXLCI3GKDRSLR3G7D3ANCNFSM4LAGTYMQ> .

Stephane Landelle · Answer 2 · Mon Jul 13 2020 21:39:35 GMT+0800 (China Standard Time)

@giurim Sorry, I realized my own mistake and deleted my comment but I guess you had already received a notification. Actually, only collecting classes whose name contains "Test" is maven-surefire-plugin's convention. I can't say I like it though...
Sorry for the noise and thanks for this project!

Gyorgy Mora · Answer 3 · Mon Jul 13 2020 22:04:44 GMT+0800 (China Standard Time)

@slandelle Hi, no worries, yes I was OOO and replied to the notification email directly on my phone. The maven-surefire-plugin convention is an interesting problem, will look into that, maybe something can be done.

Stephane Landelle · Answer 4 · Mon Jul 13 2020 22:17:26 GMT+0800 (China Standard Time)

I suspect the maven-surefire-plugin convention is something from the past, before annotations landed in Java 5 and they don't want a breaking change.

Gyorgy Mora · Answer 5 · Wed Jul 15 2020 20:56:10 GMT+0800 (China Standard Time)

Hi, you are right. The default inclusion pattern for the Maven Surefire plugin makes it only "discover" classes (files) matching the following patterns:

**/Test*.java
**/*Test.java
**/*Tests.java
**/*TestCase.java

See inclusion/exclusion configuration details: Inclusions and Exclusions of Tests

I tried the following Surefire configuration (which is pretty permissive) and I was able to run Scalatest tests with any name.

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-surefire-plugin</artifactId>
    <version>${maven.surefire.version}</version>
    <configuration>
        <includes>
            <include>*</include>
        </includes>
        <excludes>
            <exclude/>
        </excludes>
    </configuration>
</plugin>

See:
pom.xml
and
YouKnowWho.scala

Gyorgy Mora · Answer 6 · Fri May 21 2021 03:23:15 GMT+0800 (China Standard Time)

I did not really find use for supporting other discovery selectors. I also checked several Junit Engine implementations and I think it is enough to support class-based discovery.