Unexpected error for exceeded_rate
cobraextreme opened this issue · comments
cobraextreme commented
I'm getting responses with status 429 when rate limit is exceeded, which isn't in ERRORS in HelloSign::Client, and thusly raises HelloSign::Error::UnknownError.
The documentation here https://app.hellosign.com/api/reference#WarningsAndErrors suggests this should return 403 and raise HelloSign::Error::Forbidden.
I'm wondering if this is intentional, or if ERRORS and documentation just haven't been updated to match the actual api responses.
cobraextreme commented
Opened #60
Alex Griffen commented
Thanks for calling that out! The HTTPS CODE under ErrorNames is incorrect for exceeded_rate - it's a 429.
Making a comment on the PR now too.
Thanks again!