helfrichmichael / prusaslicer-novnc

Simple Docker container that serves Prusaslicer via noVNC in your web browser.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Enable VNC remote connection

fakezeta opened this issue · comments

Easy novnc is started with the -localhost flag, forwarding the port from docker does not allow VNC connection since it only listen to localhost.

 4447 1000      44768 S N /usr/bin/Xtigervnc -desktop Prusaslicer -localhost -rfbport 5900 -SecurityTypes None -AlwaysShared -AcceptKeyEvents -AcceptPointerEvents -AcceptSetDesktopSize -SendCutText -AcceptCutText :0
 4448 1000      12276 S N /usr/local/bin/easy-novnc --addr :8080 --host localhost --port 5900 --no-url-password --novnc-params resize=remote

I suggest to remove the flag and not exposing 5900 by default.
In this way the default behaviour will be the same but leave the possibility to use a VNC client if desired.

TIA

Adding this now like I just did for Cura :).

Done in 179cbd5. Let me know if it has any issues.