Giters

hed-standard / hed-python

Python validation, summary, and analysis tools for HED (Hierarchical Event Descriptors).

Home Page:https://hed-python.readthedocs.io/en/latest/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove support for the default property, include support for defaultUnits

VisLab opened this issue · comments

commented

The default attribute should be ignored going forward. It is not present in HED-3G. It's original specification would require that default units (not the ones associated with the unitClass but with the tag itself) would automatically be added when the HED string is expanded.

I am not sure that we actually have any support for adding defaultUnits when a tag is expanded. Could @IanCa check and respond to the issue so we can discuss what to do.

commented

The only handling of default that still exists is to convert it to DefaultUnits if found on units in the older xml. The older support for 'default' on tags was removed entirely.

So I think this is already done.