hcbpassos / waterfall-toolbar

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The waterfall toolbar should extend toolbar class

asajadi84 opened this issue · comments

Hello. It seems the main class of this library is extending from androidx.cardview.widget.CardView class. Therefore it's not an actual toolbar and cannot be used in coordinatorlayout alongside with scroll or recycler views. I had to do abnormal usage of paddingTop in xml of those views in order to prevent toolbar overlap.

Hi there.

As far as I can remember, it's not possible to achieve waterfall effect by extending toolbar. I think toolbar shadow is not dynamic and wouldn't change after the layout was rendered. I'm not sure this was the problem, thought. I should've documented it, but back in the day I was not a good software developer.

I've been out of Android development for almost two years by now, so things are not exactly fresh in my head, but I intend to refactor this library until the end of this year.