hauke96 / simple-task-manager

A simple tasking manager made for OpenStreetMap.

Home Page:https://stm.hauke-stieler.de

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

More descriptive task shape layer name (JOSM)

InsertUser opened this issue · comments

When I use the "Open in JOSM" button to load a task in JOSM I get two layers, one for the task shape and one for the rest of the data. The data layer uses JOSM's default naming convention, while the task shape layer gets the name "task-shape". I don't know whether this is universal or only when JOSM is set to download remote control actions in a new layer.

I think it would be useful if the task-shape layer quoted the individual task number as I have had a couple of occasions where I have had to reload the browser page while in the middle of a task and this often results in another (previous) task being shown on screen.

If using two layers is independent of settings it might also be nice if the task shape layer was flagged with upload=false to stop JOSM from complaining about un-uploaded data when deleting layers for completed tasks.

My incredibly naïve searching indicates that this might relate to task.service.ts lines 113 and 216? But I have no idea how to test this.

Hi, thanks for this feature request, all of this sounds quite useful. You're right, the line 113 is the interesting one and should be something like this:

'http://localhost:8111/load_data?new_layer=true&layer_name=task ' + task.name + '&upload_policy=never&data=' + encodeURIComponent(this.getGeometryAsOsm(task)),

I'll change this withing the next release.

Just implemented this. As I mentioned above, this will be part of the next release.