haskell / text

It would be great to get a release in the next couple of weeks for GHC 9.6.1. We are currently using 197bbcb but would be happy to upgrade. If a release isn't feasible in this timeframe then we can instead revert to a revision of 2.0.1 with the bounds bump in 197bbcb.

I think master branch is good to go. @Lysxia what’s your opinion? Would you like to take management of this release?

That looks good to me too. If you could handle it this time too that would be great. I may be more free next time.

Thank you both! Let me know when there is a commit and I'll go ahead and bump GHC's submodule.

I realised that this TODO needs to be fixed before release:

text/src/Data/Text/Internal.hs

Lines 257 to 261 in 9c29cf3

    
             A.shrinkM marr len 
        
             arr <- A.unsafeFreeze marr 
        
             return (Text arr 0 len) 
        
           {-# NOINLINE [0] pack #-} 
        
           -- TODO Do not calculate length xs upfront

Not only forcing xs in full beforehand does no good, but also shrinking does not really do anything useful, see https://gitlab.haskell.org/ghc/ghc/-/issues/22994.

text-2.0.2 is out, I've raised https://gitlab.haskell.org/ghc/ghc/-/merge_requests/10014.

	A.shrinkM marr len
	arr <- A.unsafeFreeze marr
	return (Text arr 0 len)
	{-# NOINLINE [0] pack #-}
	-- TODO Do not calculate length xs upfront

Release for GHC 9.6.1?