hashicorp / hc-install

Currently, both GitGetters run go build to compile the binary from the git repo: https://github.com/hashicorp/hcinstall/blob/main/gitref.go#L84

We probably want to customise this for some products, so perhaps add a BuildCommand to Product, and perhaps BuildFlags. It's safest not to build the product if it doesn't have BuildCommand specified.

This was done as part of #12

hc-install/product/terraform.go

Lines 44 to 48 in d9e6189

    
           BuildInstructions: &BuildInstructions{ 
        
           	GitRepoURL:    "https://github.com/hashicorp/terraform.git", 
        
           	PreCloneCheck: &build.GoIsInstalled{}, 
        
           	Build:         &build.GoBuild{DetectVendoring: true}, 
        
           },

hc-install/product/consul.go

Lines 46 to 50 in d9e6189

    
           BuildInstructions: &BuildInstructions{ 
        
           	GitRepoURL:    "https://github.com/hashicorp/consul.git", 
        
           	PreCloneCheck: &build.GoIsInstalled{}, 
        
           	Build:         &build.GoBuild{Version: v1_16}, 
        
           },

	BuildInstructions: &BuildInstructions{
	GitRepoURL: "https://github.com/hashicorp/terraform.git",
	PreCloneCheck: &build.GoIsInstalled{},
	Build: &build.GoBuild{DetectVendoring: true},
	},

Generalise GitGetters by including build command in product object