Giters

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

The `PostHashCollector` should be a `SEQUENTIAL`, not `CONCURRENT` scheduler

litt3 opened this issue · comments

commented

Problem

  • the PostHashCollector ought to be configured as a SEQUENTIAL scheduler, rather than CONCURRENT
    • the configuration file where this lives is PlatformSchedulersConfig
  • I don't believe that a CONCURRENT PostHashCollector performs that task that it was originally created for. Namely, to cheaply park hashed events before they can be consumed by the InternalEventValidator
        @ConfigProperty(defaultValue = "CONCURRENT CAPACITY(-1) UNHANDLED_TASK_METRIC")
                TaskSchedulerConfiguration postHashCollector,

More Info

  • introduced in this PR
  • I'm wondering if this misconfiguration could be responsible for the performance issues currently being observed in release/51