Giters

hashgraph / hedera-services

Crypto, token, consensus, file, and smart contract services for the Hedera public ledger

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Harden `calculateFees()` in SmartContractService

netopyr opened this issue · comments

commented

Please revisit all implementations of TransactionHandler.calculateFees() in the SmartContractService and ensure they handle invalid input data correctly. We decided that we will simply fail fast for now if an error occurs while calculating the fees, i.e., we throw a PreCheckException.

(Once all handers have been hardened this way, we can remove the pureChecks() call from the ingest workflow.)